From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24070 invoked by alias); 17 May 2013 23:09:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24060 invoked by uid 89); 17 May 2013 23:09:52 -0000 X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,TW_HW autolearn=ham version=3.3.1 Received: from e24smtp02.br.ibm.com (HELO e24smtp02.br.ibm.com) (32.104.18.86) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 23:09:51 +0000 Received: from /spool/local by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 May 2013 20:09:48 -0300 Received: from d24dlp02.br.ibm.com (9.18.248.206) by e24smtp02.br.ibm.com (10.172.0.142) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 17 May 2013 20:09:46 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 2BF031DC004E for ; Fri, 17 May 2013 19:09:46 -0400 (EDT) Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4HN8bMg35455202 for ; Fri, 17 May 2013 20:08:37 -0300 Received: from d24av03.br.ibm.com (localhost [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r4HN9jw9011476 for ; Fri, 17 May 2013 20:09:45 -0300 Received: from [9.8.15.190] ([9.8.15.190]) by d24av03.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r4HN9glJ011443; Fri, 17 May 2013 20:09:43 -0300 Message-ID: <5196B8B3.8090607@linux.vnet.ibm.com> Date: Fri, 17 May 2013 23:09:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Ulrich Weigand CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix hardware watchpoints on PowerPC servers References: <201305131319.r4DDJKnN029814@d06av02.portsmouth.uk.ibm.com> <5190F5D8.3050108@linux.vnet.ibm.com> In-Reply-To: <5190F5D8.3050108@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13051723-2194-0000-0000-000005702C18 X-SW-Source: 2013-05/txt/msg00706.txt.bz2 On 05/13/2013 11:16 AM, Edjunior Barbosa Machado wrote: > On 05/13/2013 10:19 AM, Ulrich Weigand wrote: >> So the kernel now reports it supports PPC_DEBUG_FEATURE_DATA_BP_RANGE, >> but then rejects any attempt to set a range BP of more than 8 bytes? >> And there's no way to check for this ahead of time except for checking >> the BookE hwcaps bits? That seems unfortunate ... >> >> But I guess if that's the way the kernel interface is now, we'll have to >> add that check. > > Yes, unfortunately this is the info we have from the kernel interface. > booke_debug_info.data_bp_alignment informs the alignment, which, in the > case of current bookS processors, is also the max length for the > watchpoint (8 bytes). > >> >>> * ppc-linux-nat.c (ppc_linux_region_ok_for_hw_watchpoint): Check if the >>> region is ok for a hardware watchpoint using the new ptrace interface >>> on Power servers. >> >> This is OK. >> >> As noted by Luis, it would be good to rename the "booke" terminology, >> maybe using something like "have_ptrace_hwdebug" instead of >> have_ptrace_booke_interface. But that should be a separate patch. > > I'll work on a patch following these suggestions you and Luis mentioned. > > Thanks for the feedback, Ulrich. > Checked in: http://sourceware.org/ml/gdb-cvs/2013-05/msg00146.html Thanks. -- Edjunior