Re: [RFA] gdb_expect -> gdb_test_multiple for filesym.exp

[Keith Seitz <keiths@redhat.com>]

On 05/16/2013 11:59 AM, Pedro Alves wrote:
>>      * gdb.base/filesym.exp: Use gdb_test_multiple insteadc of
>>      gdb_expect.
>
> Typo "instead".

Fixed.

>
>> +set tst "complete on \"filesy\""
>>   send_gdb "break filesy\t"
>> -gdb_expect {
>> -     -re "m\$" {
>> -    pass "complete on \"filesy\""
>> +gdb_test_multiple "" $tst {
>> +    -re "m\$" {
>> +    pass $tst
>
> Is indentation ok here?  Hard to tell from the diff.

I'm using default indentation, so I can only assume it is. FWIW, it 
looks correct to me in emacs.

>> +unset -nocomplain tst
>
> Curious.  Did you trip on another test getting confused with 'tst'
> left set?

Yes, I see this more often than not. I've sort of gotten into the habit 
of adding that, since our test suite does not attempt to keep itself 
clean, and it really doesn't harm anything.

Usually, one only runs into problems if, for example, a test uses a 
variable as an array and a subsequent test attempts to use the same 
variable as a scalar.

It can be easily removed, if you wished. Just let me know.

Keith