From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb_expect -> gdb_test_multiple for filesym.exp
Date: Thu, 16 May 2013 18:59:00 -0000 [thread overview]
Message-ID: <51952C91.5040605@redhat.com> (raw)
In-Reply-To: <51951EAC.9090607@redhat.com>
On 05/16/2013 07:00 PM, Keith Seitz wrote:
> Ok?
Fine with me.
> testsuite/ChangeLog
> 2013-05-16 Keith Seitz <keiths@redhat.com>
>
> * gdb.base/filesym.exp: Use gdb_test_multiple insteadc of
> gdb_expect.
Typo "instead".
> +set tst "complete on \"filesy\""
> send_gdb "break filesy\t"
> -gdb_expect {
> - -re "m\$" {
> - pass "complete on \"filesy\""
> +gdb_test_multiple "" $tst {
> + -re "m\$" {
> + pass $tst
Is indentation ok here? Hard to tell from the diff.
> +unset -nocomplain tst
Curious. Did you trip on another test getting confused with 'tst'
left set?
Thanks,
--
Pedro Alves
next prev parent reply other threads:[~2013-05-16 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 18:52 Keith Seitz
2013-05-16 18:59 ` Pedro Alves [this message]
2013-05-16 19:07 ` Keith Seitz
2013-05-16 19:20 ` Pedro Alves
2013-05-16 20:39 ` Keith Seitz
2013-05-17 10:52 ` Pedro Alves
2013-05-20 19:14 ` Keith Seitz
2013-05-21 0:18 ` Pedro Alves
2013-05-21 19:12 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51952C91.5040605@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox