From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101638-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28509 invoked by alias); 16 May 2013 18:59:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 28493 invoked by uid 89); 16 May 2013 18:59:33 -0000
X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 18:59:32 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GIxVDS005028	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 16 May 2013 14:59:31 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4GIxU9A027779;	Thu, 16 May 2013 14:59:30 -0400
Message-ID: <51952C91.5040605@redhat.com>
Date: Thu, 16 May 2013 18:59:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
MIME-Version: 1.0
To: Keith Seitz <keiths@redhat.com>
CC: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdb_expect -> gdb_test_multiple for filesym.exp
References: <51951EAC.9090607@redhat.com>
In-Reply-To: <51951EAC.9090607@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-05/txt/msg00644.txt.bz2

On 05/16/2013 07:00 PM, Keith Seitz wrote:

> Ok?

Fine with me.

> testsuite/ChangeLog
> 2013-05-16  Keith Seitz  <keiths@redhat.com>
> 
>     * gdb.base/filesym.exp: Use gdb_test_multiple insteadc of
>     gdb_expect.

Typo "instead".

> +set tst "complete on \"filesy\""
>  send_gdb "break filesy\t"
> -gdb_expect {
> -     -re "m\$" {
> -    pass "complete on \"filesy\""
> +gdb_test_multiple "" $tst {
> +    -re "m\$" {
> +    pass $tst

Is indentation ok here?  Hard to tell from the diff.

> +unset -nocomplain tst

Curious.  Did you trip on another test getting confused with 'tst'
left set?

Thanks,
-- 
Pedro Alves