From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2992 invoked by alias); 16 May 2013 19:07:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2942 invoked by uid 89); 16 May 2013 19:07:32 -0000 X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 19:07:31 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GJ7UwI009264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 May 2013 15:07:30 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4GJ7TJ8005088 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 16 May 2013 15:07:30 -0400 Message-ID: <51952E71.90601@redhat.com> Date: Thu, 16 May 2013 19:07:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: Pedro Alves CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] gdb_expect -> gdb_test_multiple for filesym.exp References: <51951EAC.9090607@redhat.com> <51952C91.5040605@redhat.com> In-Reply-To: <51952C91.5040605@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00646.txt.bz2 On 05/16/2013 11:59 AM, Pedro Alves wrote: >> * gdb.base/filesym.exp: Use gdb_test_multiple insteadc of >> gdb_expect. > > Typo "instead". Fixed. > >> +set tst "complete on \"filesy\"" >> send_gdb "break filesy\t" >> -gdb_expect { >> - -re "m\$" { >> - pass "complete on \"filesy\"" >> +gdb_test_multiple "" $tst { >> + -re "m\$" { >> + pass $tst > > Is indentation ok here? Hard to tell from the diff. I'm using default indentation, so I can only assume it is. FWIW, it looks correct to me in emacs. >> +unset -nocomplain tst > > Curious. Did you trip on another test getting confused with 'tst' > left set? Yes, I see this more often than not. I've sort of gotten into the habit of adding that, since our test suite does not attempt to keep itself clean, and it really doesn't harm anything. Usually, one only runs into problems if, for example, a test uses a variable as an array and a subsequent test attempts to use the same variable as a scalar. It can be easily removed, if you wished. Just let me know. Keith