From: Yao Qi <yao@codesourcery.com>
To: <lgustavo@codesourcery.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>,
Mike Frysinger <vapier@gentoo.org>
Subject: Re: [RFC, gdbserver] Avoid defining linux_read_offsets when the target does not need it
Date: Wed, 15 May 2013 14:17:00 -0000 [thread overview]
Message-ID: <5193990E.80604@codesourcery.com> (raw)
In-Reply-To: <519370AE.50908@codesourcery.com>
Luis,
I went through the patch, and didn't see something wrong. Some nits on
changelog.
On 05/15/2013 07:25 PM, Luis Machado wrote:
>
> 2013-05-15 Luis Machado<lgustavo@codesourcery.com>
>
> * linux-low.c: Move definition checks upwards for PT_TEXT_ADDR,
> PT_DATA_ADDR and PT_TEXT_END_ADDR. Update comments.
^^ Two spaces after ".".
> (linux_read_offsets): Remove PT_TEXT_ADDR, PT_DATA_ADDR and
> PT_TEXT_END_ADDR guards. Update comments.
^ Likewise.
> (linux_target_op) <read_offsets): Conditionally define to
^ ")" -> ">"
> linux_read_offsets if the target is UCLIBC and if it defines
> PT_TEXT_ADDR, PT_DATA_ADDR and PT_TEXT_END_ADDR.
--
Yao (é½å°§)
next prev parent reply other threads:[~2013-05-15 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 11:25 Luis Machado
2013-05-15 14:14 ` Pedro Alves
2013-05-16 10:34 ` Luis Machado
2013-05-15 14:17 ` Yao Qi [this message]
2013-05-15 16:06 ` Mike Frysinger
2013-05-15 16:26 ` Luis Machado
2013-05-15 17:12 ` Mike Frysinger
2013-05-15 18:08 ` Luis Machado
2013-05-15 18:51 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5193990E.80604@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox