From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101525-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4444 invoked by alias); 15 May 2013 14:17:42 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4432 invoked by uid 89); 15 May 2013 14:17:41 -0000
X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 14:17:41 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1UccWR-0002Sf-GF from Yao_Qi@mentor.com ; Wed, 15 May 2013 07:17:39 -0700
Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Wed, 15 May 2013 07:17:38 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 15 May 2013 07:17:38 -0700
Message-ID: <5193990E.80604@codesourcery.com>
Date: Wed, 15 May 2013 14:17:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: <lgustavo@codesourcery.com>
CC: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>, Mike Frysinger <vapier@gentoo.org>
Subject: Re: [RFC, gdbserver] Avoid defining linux_read_offsets when the target does not need it
References: <519370AE.50908@codesourcery.com>
In-Reply-To: <519370AE.50908@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2013-05/txt/msg00531.txt.bz2

Luis,
I went through the patch, and didn't see something wrong.  Some nits on 
changelog.

On 05/15/2013 07:25 PM, Luis Machado wrote:
>
> 2013-05-15  Luis Machado<lgustavo@codesourcery.com>
>
> 	* linux-low.c: Move definition checks upwards for PT_TEXT_ADDR,
> 	PT_DATA_ADDR and PT_TEXT_END_ADDR. Update comments.
                                           ^^  Two spaces after ".".

> 	(linux_read_offsets): Remove PT_TEXT_ADDR, PT_DATA_ADDR and
> 	PT_TEXT_END_ADDR guards. Update comments.
                                 ^ Likewise.

> 	(linux_target_op) <read_offsets): Conditionally define to
                                        ^ ")" -> ">"

> 	linux_read_offsets if the target is UCLIBC and if it defines
> 	PT_TEXT_ADDR, PT_DATA_ADDR and PT_TEXT_END_ADDR.


-- 
Yao (齐尧)