Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH, testsuite] Fix regression for gdb.mi/mi-var-create-rtti.exp
@ 2013-04-19  7:01 Luis Gustavo
  2013-04-19 10:59 ` Luis Machado
  0 siblings, 1 reply; 2+ messages in thread
From: Luis Gustavo @ 2013-04-19  7:01 UTC (permalink / raw)
  To: 'gdb-patches@sourceware.org'

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

This patch was approved a while ago, but i'm only checking it in now.

Here's what i committed.

Luis

[-- Attachment #2: 0002-var-create.diff --]
[-- Type: text/x-patch, Size: 1424 bytes --]

Index: gdb-head/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp
===================================================================
--- gdb-head.orig/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp	2013-04-17 10:24:53.083499115 +0200
+++ gdb-head/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp	2013-04-18 10:46:23.465940961 +0200
@@ -45,8 +45,10 @@ if ![mi_run_to_main] {
 # Enable "print object"
 mi_gdb_test "-gdb-set print object on" ".*"
 
-# Test creating a variable for $sp
-mi_gdb_test "-var-create sp1 * \$sp" \
+# Test creating a variable for $sp.
+# We use a explicit cast to (void *) as that is the
+# type that caused the bug this testcase is testing for.
+mi_gdb_test "-var-create sp1 * ((void*)\$sp)" \
 	    "\\^done,name=\"sp1\",numchild=\"0\",value=\"$hex\",type=\"void \\*\",has_more=\"0\"" \
 	    "-var-create sp1 * \$sp"
 gdb_exit
Index: gdb-head/gdb/ChangeLog
===================================================================
--- gdb-head.orig/gdb/ChangeLog	2013-04-18 10:39:43.913948060 +0200
+++ gdb-head/gdb/ChangeLog	2013-04-18 10:46:50.085940489 +0200
@@ -1,5 +1,10 @@
 2013-04-18  Luis Machado  <lgustavo@codesourcery.com>
 
+	* gdb.mi/mi-var-create-rtti.exp: Create a variable of
+	type void *.
+
+2013-04-18  Luis Machado  <lgustavo@codesourcery.com>
+
 	* ppc-linux-nat.c (ppc_linux_new_thread): Clear the new thread's
 	debug state prior to replicating existing hardware watchpoints or
 	breakpoints.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH, testsuite] Fix regression for gdb.mi/mi-var-create-rtti.exp
  2013-04-19  7:01 [PATCH, testsuite] Fix regression for gdb.mi/mi-var-create-rtti.exp Luis Gustavo
@ 2013-04-19 10:59 ` Luis Machado
  0 siblings, 0 replies; 2+ messages in thread
From: Luis Machado @ 2013-04-19 10:59 UTC (permalink / raw)
  Cc: 'gdb-patches@sourceware.org'

On 04/18/2013 12:08 PM, Luis Gustavo wrote:
> This patch was approved a while ago, but i'm only checking it in now.
>
> Here's what i committed.
>
> Luis

I should probably clarify that although the attached patch changed 
gdb/ChangeLog, the real commit did the right thing with 
gdb/testsuite/ChangeLog.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-18 10:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-19  7:01 [PATCH, testsuite] Fix regression for gdb.mi/mi-var-create-rtti.exp Luis Gustavo
2013-04-19 10:59 ` Luis Machado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox