Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Gustavo <luis_gustavo@mentor.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: [PATCH, testsuite] Fix regression for gdb.mi/mi-var-create-rtti.exp
Date: Fri, 19 Apr 2013 07:01:00 -0000	[thread overview]
Message-ID: <516FC617.5040409@mentor.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

This patch was approved a while ago, but i'm only checking it in now.

Here's what i committed.

Luis

[-- Attachment #2: 0002-var-create.diff --]
[-- Type: text/x-patch, Size: 1424 bytes --]

Index: gdb-head/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp
===================================================================
--- gdb-head.orig/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp	2013-04-17 10:24:53.083499115 +0200
+++ gdb-head/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp	2013-04-18 10:46:23.465940961 +0200
@@ -45,8 +45,10 @@ if ![mi_run_to_main] {
 # Enable "print object"
 mi_gdb_test "-gdb-set print object on" ".*"
 
-# Test creating a variable for $sp
-mi_gdb_test "-var-create sp1 * \$sp" \
+# Test creating a variable for $sp.
+# We use a explicit cast to (void *) as that is the
+# type that caused the bug this testcase is testing for.
+mi_gdb_test "-var-create sp1 * ((void*)\$sp)" \
 	    "\\^done,name=\"sp1\",numchild=\"0\",value=\"$hex\",type=\"void \\*\",has_more=\"0\"" \
 	    "-var-create sp1 * \$sp"
 gdb_exit
Index: gdb-head/gdb/ChangeLog
===================================================================
--- gdb-head.orig/gdb/ChangeLog	2013-04-18 10:39:43.913948060 +0200
+++ gdb-head/gdb/ChangeLog	2013-04-18 10:46:50.085940489 +0200
@@ -1,5 +1,10 @@
 2013-04-18  Luis Machado  <lgustavo@codesourcery.com>
 
+	* gdb.mi/mi-var-create-rtti.exp: Create a variable of
+	type void *.
+
+2013-04-18  Luis Machado  <lgustavo@codesourcery.com>
+
 	* ppc-linux-nat.c (ppc_linux_new_thread): Clear the new thread's
 	debug state prior to replicating existing hardware watchpoints or
 	breakpoints.

             reply	other threads:[~2013-04-18 10:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  7:01 Luis Gustavo [this message]
2013-04-19 10:59 ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516FC617.5040409@mentor.com \
    --to=luis_gustavo@mentor.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox