Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: brobecker@adacore.com, gdb-patches@sourceware.org,
	       jan.kratochvil@redhat.com
Subject: unbreak Windows hosted cross debugger builds (was: Re: one week to gdb-7.6 release?)
Date: Sat, 06 Apr 2013 06:16:00 -0000	[thread overview]
Message-ID: <515F270A.2010403@redhat.com> (raw)
In-Reply-To: <837gkhfnoi.fsf@gnu.org>

On 04/05/2013 08:21 AM, Eli Zaretskii wrote:

>> OK to commit, including the branch (which will get a different change,
>> since there's no need to remove the previous commit there)?

OK with me.

I'd have personally preferred a version that adds "get_absolute_argv0" to
both mingw-hdep.c and posix-hdep.c, but we can do that if
we find a need to do more than xstrdup for !Windows...

>>
>> 2013-04-02  Eli Zaretskii  <eliz@gnu.org>
>>
>> 	* windows-nat.c (windows_get_absolute_argv0): Move from here...
>> 	* mingw-hdep.c (windows_get_absolute_argv0): ...to here.
>> 	Include main.h.
>>
>> 	* windows-nat.h (windows_get_absolute_argv0): Move prototype from
>> 	here...
>> 	* main.h (windows_get_absolute_argv0): ...to here

Missing period after "here".

-- 
Pedro Alves


  reply	other threads:[~2013-04-05 19:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 16:09 one week to gdb-7.6 release? Joel Brobecker
2013-03-20 16:14 ` Pedro Alves
2013-03-20 17:06 ` Jan Kratochvil
2013-03-20 17:08 ` Joel Sherrill
2013-03-20 17:20 ` Eli Zaretskii
2013-03-23 22:59   ` Eli Zaretskii
2013-03-24  0:01     ` Joel Brobecker
2013-03-24  0:07       ` Eli Zaretskii
2013-03-25 16:58         ` Joel Brobecker
2013-03-25 17:46           ` Eli Zaretskii
2013-03-25 18:10             ` Joel Brobecker
2013-03-29  8:02               ` Joel Brobecker
2013-03-29 14:03                 ` Eli Zaretskii
2013-03-29 19:53                   ` Joel Brobecker
2013-04-02 18:05                   ` Eli Zaretskii
2013-04-05 13:03                     ` Eli Zaretskii
2013-04-06  6:16                       ` Pedro Alves [this message]
2013-04-06 15:41                         ` unbreak Windows hosted cross debugger builds gdb-7.6 release?) Eli Zaretskii
2013-03-29 15:23                 ` one week to gdb-7.6 release? Ralf Corsepius
2013-03-29 16:42                   ` m32r sim was " Joel Sherrill
2013-03-29 17:18                     ` Mike Frysinger
2013-03-29 19:53                       ` Joel Brobecker
2013-03-29 20:24                         ` Joel Sherrill
2013-03-29 21:44                           ` Joel Brobecker
2013-04-04 13:03                         ` Ralf Corsepius
2013-04-10 15:01                           ` Joel Brobecker
2013-03-25 19:08             ` Mark Kettenis
2013-03-25 19:12               ` Eli Zaretskii
2013-04-06 21:49                 ` Pedro Alves
2013-04-07  3:58                   ` Eli Zaretskii
2013-03-23 23:38   ` Joel Sherrill
2013-03-24  0:12     ` Mike Frysinger
2013-03-20 18:23 ` Ralf Corsepius
2013-04-01 19:56 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515F270A.2010403@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox