Re: m32r sim was Re: one week to gdb-7.6 release?

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1863 bytes --]

On Friday 29 March 2013 10:46:22 Joel Sherrill wrote:
> On 3/29/2013 1:54 AM, Ralf Corsepius wrote:
> > Using the same set of configuration options, I have been using for
> > gdb-7.5.x, all targets build fine on Linux.
> > 
> > However, there is a new breakdown for the m32r on
> > mingw32-w64-{x86_64,i386}:
> > 
> > ..../configure --build=i386-pc-linux-gnu \
> > --host=x86_64-w64-mingw32 --target=m32r-rtems4.11
> > --enable-sim [...] \
> > ...
> > checking how to recognize dependent libraries... configure: error:
> > Sorry, but hardware support in this simulator unconditionally
> > relies on dv-sockser.o which is unavailable for your host. Please fix
> > this simulator.
> > ...
> > 
> > As gdb-7.5.x built fine with the same configuration, this to me
> > qualifies as a regression - Or is this just a latent, so far silently
> > accepted, but dysfunctional part being revealed by the new configuration
> > magic?
> 
> Looking back at 7.5.91, I see that m32r unconditionally uses
> dv-sockser.o and
> I don't know how it built before.

two reasons:
 - it never defined HAVE_DV_SOCKSER
 - it adds dv-sockser.o in Makefile.in only to then clear the variable
so it had all the framework for the code, but never actually enabled it :).  
your patch actually fixed that part.

> The references to dv-sockser.o methods appear to be properly
> conditionalized in the code.  So it is the Makefile.in and our
> interpretation that the simulated
> hardware should be "always on" versus "yes enabled" by default.
> 
> Attached is an untested patch.

you should also update m32r/tconfig.in and remove the 3 lines related to #if 
0/HAVE_DV_SOCKSER.

also, you'll need to apply the same fix to frv.  it too has proper 
HAVE_DV_SOCKSER conditionals, and explicitly lists it in Makefile.in, only to 
later disable it.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]