Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread

[Yao Qi <yao@codesourcery.com>]

On 03/25/2013 11:45 AM, Hui Zhu wrote:
> But my patch is for the issue inside the function create_breakpoint.
> I post the mi commands to show the issue is because it call
> create_breakpoint with parse_condition_and_thread is 0 and easy to
> show how it can affect the behavior of a pending breakpoint.
> I think this issue also affect other functions that call
> create_breakpoint with parse_condition_and_thread is 0.

Hui,
The comment of create_breakpoint says something,

/* Set a breakpoint.  This function is shared between CLI and MI
    functions for setting a breakpoint.  This function has two major
    modes of operations, selected by the PARSE_CONDITION_AND_THREAD
    parameter.  If non-zero, the function will parse arg, extracting
    breakpoint location, address and thread.  Otherwise, ARG is just
    the location of breakpoint, with condition and thread specified by
    the COND_STRING and THREAD parameters.  If INTERNAL is non-zero,
    the breakpoint number will be allocated from the internal
    breakpoint count.  Returns true if any breakpoint was created;
    false otherwise.  */

in other words, it is invalid to put condition into ARG and set 
parse_condition_and_thread 0.

-- 
Yao (齐尧)