From: Keith Seitz <keiths@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Hui Zhu <hui_zhu@mentor.com>, Tom Tromey <tromey@redhat.com>,
Hui Zhu <teawater@gmail.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread
Date: Mon, 08 Apr 2013 07:56:00 -0000 [thread overview]
Message-ID: <5160987A.5030308@redhat.com> (raw)
In-Reply-To: <515F0EED.4040105@redhat.com>
On 04/05/2013 10:50 AM, Pedro Alves wrote:
> I think you're on the right track here.
That's good to know. :-) Honestly, though, that was just meant as an
example -- not a definitive solution to the problem.
> That'd mean that e.g., for a future MI dprintf command, we'd accept
> the remainder of ARG as extra string.
Gah. I totally spaced on MI.
> I made it "parse_arg", as that'll remain stable even
> when more explicit parameters are added, and,
>
> break_command_1:
>
> create_breakpoint (get_current_arch (),
> arg,
> NULL, 0, NULL, 1 /* parse arg */,
>
> we even have comments calling it that already too.
A very welcome change.
> WDYT?
It looks good to me.
Thank you again for your review of my review. Hopefully next time I'll
be a bit better at it!
Keith
next prev parent reply other threads:[~2013-04-06 21:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-24 12:05 Hui Zhu
2013-03-25 0:53 ` Keith Seitz
2013-03-25 7:54 ` Hui Zhu
2013-03-25 16:14 ` Yao Qi
2013-03-25 16:27 ` Hui Zhu
2013-03-25 19:32 ` Tom Tromey
2013-03-25 19:58 ` Keith Seitz
2013-03-26 11:16 ` Hui Zhu
2013-04-05 19:18 ` Pedro Alves
2013-04-08 7:56 ` Keith Seitz [this message]
2013-04-08 17:54 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5160987A.5030308@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=palves@redhat.com \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox