From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9368 invoked by alias); 25 Mar 2013 13:33:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9355 invoked by uid 89); 25 Mar 2013 13:33:03 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 13:33:01 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UK7WE-0004U2-UU from Yao_Qi@mentor.com ; Mon, 25 Mar 2013 06:32:58 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 25 Mar 2013 06:32:58 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 25 Mar 2013 06:32:57 -0700 Message-ID: <515051B8.3010801@codesourcery.com> Date: Mon, 25 Mar 2013 16:14:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hui Zhu CC: Keith Seitz , Hui Zhu , gdb-patches ml Subject: Re: [PATCH] Fix create pending breakpoint handle extra_string issue if not parse_condition_and_thread References: <514E8D6C.2010606@mentor.com> <514EEB43.6040101@redhat.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-03/txt/msg00933.txt.bz2 On 03/25/2013 11:45 AM, Hui Zhu wrote: > But my patch is for the issue inside the function create_breakpoint. > I post the mi commands to show the issue is because it call > create_breakpoint with parse_condition_and_thread is 0 and easy to > show how it can affect the behavior of a pending breakpoint. > I think this issue also affect other functions that call > create_breakpoint with parse_condition_and_thread is 0. Hui, The comment of create_breakpoint says something, /* Set a breakpoint. This function is shared between CLI and MI functions for setting a breakpoint. This function has two major modes of operations, selected by the PARSE_CONDITION_AND_THREAD parameter. If non-zero, the function will parse arg, extracting breakpoint location, address and thread. Otherwise, ARG is just the location of breakpoint, with condition and thread specified by the COND_STRING and THREAD parameters. If INTERNAL is non-zero, the breakpoint number will be allocated from the internal breakpoint count. Returns true if any breakpoint was created; false otherwise. */ in other words, it is invalid to put condition into ARG and set parse_condition_and_thread 0. -- Yao (齐尧)