* [RFC/TileGX] enable gdbserver in configure.tgt for tilegx
@ 2013-02-27 3:28 Jiong Wang
2013-02-27 14:15 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Jiong Wang @ 2013-02-27 3:28 UTC (permalink / raw)
To: gdb-patches; +Cc: Pedro Alves, Walter Lee
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
this patch enable gdbserver build for tilegx, and replace whitespaces
with tab.
gdb/ChangeLog:
* configure.tgt: Enable gdbserver for tilegx.
Replace whitespaces with tab.
please review, thanks.
---
Regards,
Jiong
Tilera Corporation
[-- Attachment #2: gdbserver.patch --]
[-- Type: text/x-patch, Size: 516 bytes --]
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index feb2059..eac949a 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -596,10 +596,11 @@ tic6x-*-*)
;;
tilegx-*-linux*)
- # Target: TILE-Gx
- gdb_target_obs="tilegx-tdep.o tilegx-linux-tdep.o solib-svr4.o \
+ # Target: TILE-Gx
+ gdb_target_obs="tilegx-tdep.o tilegx-linux-tdep.o solib-svr4.o \
symfile-mem.o glibc-tdep.o linux-tdep.o"
- ;;
+ build_gdbserver=yes
+ ;;
xstormy16-*-*)
# Target: Sanyo Xstormy16a processor
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC/TileGX] enable gdbserver in configure.tgt for tilegx
2013-02-27 3:28 [RFC/TileGX] enable gdbserver in configure.tgt for tilegx Jiong Wang
@ 2013-02-27 14:15 ` Pedro Alves
2013-02-27 14:17 ` Jiong Wang
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2013-02-27 14:15 UTC (permalink / raw)
To: Jiong Wang; +Cc: gdb-patches, Walter Lee
On 02/27/2013 03:28 AM, Jiong Wang wrote:
> this patch enable gdbserver build for tilegx, and replace whitespaces
> with tab.
We prefer whitespace/formatting fixes to be separate from real changes (unless
the patch actually touches all the lines anyway).
Please commit first a patch that fixes the whitespace, and then as another
patch the gdbserver bit.
Write as:
* configure.tgt (tilegx-*-linux*): Replace whitespace with tab.
and:
* configure.tgt (tilegx-*-linux*): Enable gdbserver.
Thanks.
>
> gdb/ChangeLog:
> * configure.tgt: Enable gdbserver for tilegx.
> Replace whitespaces with tab.
>
> please review, thanks.
>
> ---
> Regards,
> Jiong
> Tilera Corporation
>
>
--
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC/TileGX] enable gdbserver in configure.tgt for tilegx
2013-02-27 14:15 ` Pedro Alves
@ 2013-02-27 14:17 ` Jiong Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jiong Wang @ 2013-02-27 14:17 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Walter Lee
On 2013/2/27 22:15, Pedro Alves wrote:
> On 02/27/2013 03:28 AM, Jiong Wang wrote:
>> this patch enable gdbserver build for tilegx, and replace whitespaces
>> with tab.
> We prefer whitespace/formatting fixes to be separate from real changes (unless
> the patch actually touches all the lines anyway).
>
> Please commit first a patch that fixes the whitespace, and then as another
> patch the gdbserver bit.
I see. thanks for point out.
Regards,
Jiong
>
>> gdb/ChangeLog:
>> * configure.tgt: Enable gdbserver for tilegx.
>> Replace whitespaces with tab.
>>
>> please review, thanks.
>>
>> ---
>> Regards,
>> Jiong
>> Tilera Corporation
>>
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-27 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-27 3:28 [RFC/TileGX] enable gdbserver in configure.tgt for tilegx Jiong Wang
2013-02-27 14:15 ` Pedro Alves
2013-02-27 14:17 ` Jiong Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox