From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20498 invoked by alias); 27 Feb 2013 14:15:27 -0000 Received: (qmail 20482 invoked by uid 22791); 27 Feb 2013 14:15:25 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Feb 2013 14:15:20 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1REFJpj028615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Feb 2013 09:15:19 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1REFIuX026851; Wed, 27 Feb 2013 09:15:18 -0500 Message-ID: <512E14F5.8000906@redhat.com> Date: Wed, 27 Feb 2013 14:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Jiong Wang CC: gdb-patches@sourceware.org, Walter Lee Subject: Re: [RFC/TileGX] enable gdbserver in configure.tgt for tilegx References: <512D7D6A.3080106@tilera.com> In-Reply-To: <512D7D6A.3080106@tilera.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00682.txt.bz2 On 02/27/2013 03:28 AM, Jiong Wang wrote: > this patch enable gdbserver build for tilegx, and replace whitespaces > with tab. We prefer whitespace/formatting fixes to be separate from real changes (unless the patch actually touches all the lines anyway). Please commit first a patch that fixes the whitespace, and then as another patch the gdbserver bit. Write as: * configure.tgt (tilegx-*-linux*): Replace whitespace with tab. and: * configure.tgt (tilegx-*-linux*): Enable gdbserver. Thanks. > > gdb/ChangeLog: > * configure.tgt: Enable gdbserver for tilegx. > Replace whitespaces with tab. > > please review, thanks. > > --- > Regards, > Jiong > Tilera Corporation > > -- Pedro Alves