From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix a bug in cmd_qtbuffer.
Date: Tue, 26 Feb 2013 14:14:00 -0000 [thread overview]
Message-ID: <512CC30B.6000806@codesourcery.com> (raw)
In-Reply-To: <512C9B27.2080503@redhat.com>
On 02/26/2013 07:23 PM, Pedro Alves wrote:
> On 02/25/2013 03:11 AM, Yao Qi wrote:
>> Hi,
>> When playing with packet "qTBuffer", I find a bug in cmd_qtbuffer. We
>> don't have to set '\0' to OWN_BUF, because convert_int_to_ascii did
>> that. On the other hand, it is incorrect to set '\0' to own_buf[num]
>> because convert_int_to_ascii writes 2 * num of bytes to OWN_BUF, it
>> is correct to set '\0' to own_buf[2 * num]. This patch fixes the bug
>> I found when using "qTBuffer".
>>
>> Regression tested on x86_64-linux. OK?
>
> OK, thanks.
>
Thanks for the review. Committed.
--
Yao (é½å°§)
prev parent reply other threads:[~2013-02-26 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 3:12 Yao Qi
2013-02-26 11:23 ` Pedro Alves
2013-02-26 14:14 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512CC30B.6000806@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox