From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2295 invoked by alias); 26 Feb 2013 14:14:35 -0000 Received: (qmail 2254 invoked by uid 22791); 26 Feb 2013 14:14:33 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Feb 2013 14:14:28 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UALIZ-0003Uf-HH from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 26 Feb 2013 06:14:27 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 26 Feb 2013 06:14:26 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Tue, 26 Feb 2013 06:14:26 -0800 Message-ID: <512CC30B.6000806@codesourcery.com> Date: Tue, 26 Feb 2013 14:14:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Subject: Re: [PATCH] Fix a bug in cmd_qtbuffer. References: <1361761876-10017-1-git-send-email-yao@codesourcery.com> <512C9B27.2080503@redhat.com> In-Reply-To: <512C9B27.2080503@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00654.txt.bz2 On 02/26/2013 07:23 PM, Pedro Alves wrote: > On 02/25/2013 03:11 AM, Yao Qi wrote: >> Hi, >> When playing with packet "qTBuffer", I find a bug in cmd_qtbuffer. We >> don't have to set '\0' to OWN_BUF, because convert_int_to_ascii did >> that. On the other hand, it is incorrect to set '\0' to own_buf[num] >> because convert_int_to_ascii writes 2 * num of bytes to OWN_BUF, it >> is correct to set '\0' to own_buf[2 * num]. This patch fixes the bug >> I found when using "qTBuffer". >> >> Regression tested on x86_64-linux. OK? > > OK, thanks. > Thanks for the review. Committed. -- Yao (齐尧)