Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Fix a bug in cmd_qtbuffer.
Date: Mon, 25 Feb 2013 03:12:00 -0000	[thread overview]
Message-ID: <1361761876-10017-1-git-send-email-yao@codesourcery.com> (raw)

Hi,
When playing with packet "qTBuffer", I find a bug in cmd_qtbuffer.  We
don't have to set '\0' to OWN_BUF, because convert_int_to_ascii did
that.  On the other hand, it is incorrect to set '\0' to own_buf[num]
because convert_int_to_ascii writes 2 * num of bytes to OWN_BUF, it
is correct to set '\0' to own_buf[2 * num].  This patch fixes the bug
I found when using "qTBuffer".

Regression tested on x86_64-linux.  OK?

gdb/gdbserver:

2013-02-25  Yao Qi  <yao@codesourcery.com>

	* tracepoint.c (cmd_qtbuffer): Don't set '\0' in OWN_BUF.
---
 gdb/gdbserver/tracepoint.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/tracepoint.c b/gdb/gdbserver/tracepoint.c
index 95c55ad..ba681c4 100644
--- a/gdb/gdbserver/tracepoint.c
+++ b/gdb/gdbserver/tracepoint.c
@@ -4002,7 +4002,6 @@ cmd_qtbuffer (char *own_buf)
     num = (PBUFSIZ - 16) / 2;
 
   convert_int_to_ascii (tbp, own_buf, num);
-  own_buf[num] = '\0';
 }
 
 static void
-- 
1.7.7.6


             reply	other threads:[~2013-02-25  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25  3:12 Yao Qi [this message]
2013-02-26 11:23 ` Pedro Alves
2013-02-26 14:14   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361761876-10017-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox