Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Marcus Shawcroft <marcus.shawcroft@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] Fix layout in aarch64-tdep.c
Date: Tue, 05 Feb 2013 12:58:00 -0000	[thread overview]
Message-ID: <511101D1.1000903@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

This patch fixes the gripe:

0a1,2
 > gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end 
of a line
gdb/aarch64-tdep.c:776:                                  pv_add_constant 
(regs[rn], imm)) ||


OK?

/Marcus

ChangeLog:
 

        * aarch64-tdep.c (aarch64_analyze_prologue): Refactor if statement
        with trailing || operator.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-aarch64-tdep-layout.diff --]
[-- Type: text/x-patch; name=0001-aarch64-tdep-layout.diff, Size: 607 bytes --]

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index ac4ed17..ebc78d6 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -773,8 +773,10 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch,
 	     (perhaps because rn is not known) then we should abandon
 	     further prologue analysis.  */
 	  if (pv_area_store_would_trash (stack,
-					 pv_add_constant (regs[rn], imm)) ||
-	      pv_area_store_would_trash (stack,
+					 pv_add_constant (regs[rn], imm)))
+	    break;
+
+	  if (pv_area_store_would_trash (stack,
 					 pv_add_constant (regs[rn], imm + 8)))
 	    break;
 

             reply	other threads:[~2013-02-05 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 12:58 Marcus Shawcroft [this message]
2013-02-05 13:04 ` Pierre Muller
2013-02-05 13:06 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511101D1.1000903@arm.com \
    --to=marcus.shawcroft@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox