From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30620 invoked by alias); 5 Feb 2013 12:58:07 -0000 Received: (qmail 30555 invoked by uid 22791); 5 Feb 2013 12:58:05 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Feb 2013 12:57:57 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 05 Feb 2013 12:57:56 +0000 Received: from [10.1.72.50] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 5 Feb 2013 12:57:53 +0000 Message-ID: <511101D1.1000903@arm.com> Date: Tue, 05 Feb 2013 12:58:00 -0000 From: Marcus Shawcroft User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [PATCH] Fix layout in aarch64-tdep.c X-MC-Unique: 113020512575602101 Content-Type: multipart/mixed; boundary="------------070107060009080001020506" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00115.txt.bz2 This is a multi-part message in MIME format. --------------070107060009080001020506 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Content-length: 360 This patch fixes the gripe: 0a1,2 > gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end=20 of a line gdb/aarch64-tdep.c:776: pv_add_constant=20 (regs[rn], imm)) || OK? /Marcus ChangeLog: =20 * aarch64-tdep.c (aarch64_analyze_prologue): Refactor if statement with trailing || operator.= --------------070107060009080001020506 Content-Type: text/x-patch; name=0001-aarch64-tdep-layout.diff Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-aarch64-tdep-layout.diff" Content-length: 595 diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index ac4ed17..ebc78d6 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -773,8 +773,10 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch, (perhaps because rn is not known) then we should abandon further prologue analysis. */ if (pv_area_store_would_trash (stack, - pv_add_constant (regs[rn], imm)) || - pv_area_store_would_trash (stack, + pv_add_constant (regs[rn], imm))) + break; + + if (pv_area_store_would_trash (stack, pv_add_constant (regs[rn], imm + 8))) break; =20= --------------070107060009080001020506--