From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Marcus Shawcroft'" <marcus.shawcroft@arm.com>,
<gdb-patches@sourceware.org>
Subject: RE: [PATCH] Fix layout in aarch64-tdep.c
Date: Tue, 05 Feb 2013 13:04:00 -0000 [thread overview]
Message-ID: <005801ce03a1$42d47180$c87d5480$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <511101D1.1000903@arm.com>
All changes that simply remove the additional entry in the ARI
web page, and generated a "New ARI warning" message,
can be checked in as obvious.
Thus, please do commit this fix,
the best would be to mention ARI rule in the ChangeLog entry.
Something like
* aarch64-tdep.c (aarch64_analyze_prologue): ARI fix:
Refactor if statement to avoid trailing || operator.
Pierre Muller
as ARI maintainer.
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Marcus Shawcroft
> Envoyé : mardi 5 février 2013 13:58
> À : gdb-patches@sourceware.org
> Objet : [PATCH] Fix layout in aarch64-tdep.c
>
> This patch fixes the gripe:
>
> 0a1,2
> > gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end
> of a line
> gdb/aarch64-tdep.c:776: pv_add_constant
> (regs[rn], imm)) ||
>
>
> OK?
>
> /Marcus
>
> ChangeLog:
>
>
> * aarch64-tdep.c (aarch64_analyze_prologue): Refactor if statement
> with trailing || operator.
next prev parent reply other threads:[~2013-02-05 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 12:58 Marcus Shawcroft
2013-02-05 13:04 ` Pierre Muller [this message]
2013-02-05 13:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005801ce03a1$42d47180$c87d5480$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox