From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98266-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 836 invoked by alias); 5 Feb 2013 13:04:14 -0000
Received: (qmail 824 invoked by uid 22791); 5 Feb 2013 13:04:13 -0000
X-SWARE-Spam-Status: No, hits=-0.4 required=5.0	tests=AWL,BAYES_50,KHOP_THREADED,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Feb 2013 13:04:08 +0000
Received: from md13.u-strasbg.fr (md13.u-strasbg.fr [130.79.200.248])           by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r15D40UF010650           ; Tue, 5 Feb 2013 14:04:01 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116])           by md13.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r15D3xYc003227           ; Tue, 5 Feb 2013 14:04:00 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN)          by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r15D3wPD024539 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)          ; Tue, 5 Feb 2013 14:03:59 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Marcus Shawcroft'" <marcus.shawcroft@arm.com>,        <gdb-patches@sourceware.org>
References: <511101D1.1000903@arm.com>
In-Reply-To: <511101D1.1000903@arm.com>
Subject: RE: [PATCH] Fix layout in aarch64-tdep.c
Date: Tue, 05 Feb 2013 13:04:00 -0000
Message-ID: <005801ce03a1$42d47180$c87d5480$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00116.txt.bz2

 All changes that simply remove the additional entry in the ARI
web page, and generated a "New ARI warning" message,
can be checked in as obvious.

  Thus, please do commit this fix,
the best would be to mention ARI rule in the ChangeLog entry.

Something like

	* aarch64-tdep.c (aarch64_analyze_prologue): ARI fix:
	Refactor if statement to avoid trailing || operator.


Pierre Muller
as ARI maintainer.=20

> -----Message d'origine-----
> De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Marcus Shawcroft
> Envoy=E9=A0: mardi 5 f=E9vrier 2013 13:58
> =C0=A0: gdb-patches@sourceware.org
> Objet=A0: [PATCH] Fix layout in aarch64-tdep.c
>=20
> This patch fixes the gripe:
>=20
> 0a1,2
>  > gdb/aarch64-tdep.c:776: code: OP eol: Do not use &&, or || at the end
> of a line
> gdb/aarch64-tdep.c:776:                                  pv_add_constant
> (regs[rn], imm)) ||
>=20
>=20
> OK?
>=20
> /Marcus
>=20
> ChangeLog:
>=20
>=20
>         * aarch64-tdep.c (aarch64_analyze_prologue): Refactor if statement
>         with trailing || operator.