Re: [PATCH] gdbserver ptrace() argument type cleanups.

[Pedro Alves <palves@redhat.com>]

Hi Marcus,

On 02/04/2013 05:30 PM, Marcus Shawcroft wrote:

> This patch is ripped out of the aarch64 gdbserver patch here:
> 
> http://sourceware.org/ml/gdb-patches/2013-01/msg00535.html
> 
> These changes are not directly related to the aarch64 port itself. Since ptrace() has a variadic prototype, the anonymous arguments, notably arguments 3 and 4, should be given their correct types.

Excellent.  Thanks for doing this.

>    gdb/gdbserver/
> 
>         * linux-low.c (handle_extended_wait, linux_create_inferior)
>         (linux_attach_lwp_1, linux_kill_one_lwp, linux_attach_one_lwp)
>         (dequeue_one_deferred_signal, linux_resume_one_thread)
>         (fetch_register, linux_write_memory, linux_enable_event_reporting)
>         (linux_tracefork_grandchild, linux_test_for_tracefork)
>         (linux_read_offsets, linux_xfer_siginfo, linux_xfer_siginfo ): Add

Spurious space ------------------------------------------------------^

>         PTRACE_ARG3_TYPE and PTRACE_ARG4_TYPE cast to ptrace arguments
>         where the argument is 0.

This is OK.

Thanks!

-- 
Pedro Alves