Re: [PATCH] gdbserver ptrace() argument type cleanups.

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Mon, 04 Feb 2013 17:30:48 +0000
> From: Marcus Shawcroft <marcus.shawcroft@arm.com>
> 
> Hi,
> 
> This patch is ripped out of the aarch64 gdbserver patch here:
> 
> http://sourceware.org/ml/gdb-patches/2013-01/msg00535.html
> 
> These changes are not directly related to the aarch64 port itself.
> Since ptrace() has a variadic prototype, the anonymous arguments,
> notably arguments 3 and 4, should be given their correct types.
> 
> /Marcus
> 
> Proposed ChangeLog:
> 
>     gdb/gdbserver/
> 
>          * linux-low.c (handle_extended_wait, linux_create_inferior)
>          (linux_attach_lwp_1, linux_kill_one_lwp, linux_attach_one_lwp)
>          (dequeue_one_deferred_signal, linux_resume_one_thread)
>          (fetch_register, linux_write_memory, linux_enable_event_reporting)
>          (linux_tracefork_grandchild, linux_test_for_tracefork)
>          (linux_read_offsets, linux_xfer_siginfo, linux_xfer_siginfo ): Add
>          PTRACE_ARG3_TYPE and PTRACE_ARG4_TYPE cast to ptrace arguments
>          where the argument is 0.

> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> index 8988509..c52cd2e 100644
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> @@ -445,7 +445,8 @@ handle_extended_wait (struct lwp_info *event_child, int=
>  wstat)
>        unsigned long new_pid;
>        int ret, status;
> =20
> -      ptrace (PTRACE_GETEVENTMSG, lwpid_of (event_child), 0, &new_pid);
> +      ptrace (PTRACE_GETEVENTMSG, lwpid_of (event_child), (PTRACE_ARG3_TYPE) 0,
> +	      &new_pid);

I'd use the word "obfuscation" instead of "cleanup".