From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4182 invoked by alias); 4 Feb 2013 17:35:50 -0000 Received: (qmail 4031 invoked by uid 22791); 4 Feb 2013 17:35:48 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Feb 2013 17:35:38 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r14HZaSW004711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 4 Feb 2013 12:35:36 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r14HZYbD018510; Mon, 4 Feb 2013 12:35:35 -0500 Message-ID: <510FF165.4090906@redhat.com> Date: Mon, 04 Feb 2013 17:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Marcus Shawcroft CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdbserver ptrace() argument type cleanups. References: <510FF048.8070701@arm.com> In-Reply-To: <510FF048.8070701@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00081.txt.bz2 Hi Marcus, On 02/04/2013 05:30 PM, Marcus Shawcroft wrote: > This patch is ripped out of the aarch64 gdbserver patch here: > > http://sourceware.org/ml/gdb-patches/2013-01/msg00535.html > > These changes are not directly related to the aarch64 port itself. Since ptrace() has a variadic prototype, the anonymous arguments, notably arguments 3 and 4, should be given their correct types. Excellent. Thanks for doing this. > gdb/gdbserver/ > > * linux-low.c (handle_extended_wait, linux_create_inferior) > (linux_attach_lwp_1, linux_kill_one_lwp, linux_attach_one_lwp) > (dequeue_one_deferred_signal, linux_resume_one_thread) > (fetch_register, linux_write_memory, linux_enable_event_reporting) > (linux_tracefork_grandchild, linux_test_for_tracefork) > (linux_read_offsets, linux_xfer_siginfo, linux_xfer_siginfo ): Add Spurious space ------------------------------------------------------^ > PTRACE_ARG3_TYPE and PTRACE_ARG4_TYPE cast to ptrace arguments > where the argument is 0. This is OK. Thanks! -- Pedro Alves