From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Remove queue_position.
Date: Thu, 24 Jan 2013 18:53:00 -0000 [thread overview]
Message-ID: <51018313.9030701@redhat.com> (raw)
In-Reply-To: <1358990040-10962-2-git-send-email-yao@codesourcery.com>
On 01/24/2013 01:13 AM, Yao Qi wrote:
> enum HEAD is never used and AFAICS, we don't need to insert element to
> event_queue in different places of the queue, so 'enum
> queue_position' is not needed. This patch is to remove it and
> simplify 'async_queue_event'.
Yeah. Thanks. This was one of the things I simplified
when I forked gdbserver's event-loop.c, but never got
to cleanup on the GDB side. Nowadays, I think that forking
was a mistake, and we should make gdb and gdbserver share
the same code.
>
> gdb:
>
> 2013-01-24 Yao Qi <yao@codesourcery.com>
>
> * event-loop.c (async_queue_event): Remove one parameter
> 'position'. Remove code handling 'position' == TAIL.
> (gdb_wait_for_event): Caller update.
> (check_async_event_handlers): Caller update.
> (poll_timers): Caller update.
> * event-loop.h (enum queue_position): Remove.
Okay, thanks.
--
Pedro Alves
next prev parent reply other threads:[~2013-01-24 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 1:15 [PATCH 1/3] gdbserver: replace event_queue with QUEUE Yao Qi
2013-01-24 1:15 ` [PATCH 3/3] gdb: " Yao Qi
2013-01-24 19:08 ` Pedro Alves
2013-01-25 7:02 ` Yao Qi
2013-01-25 9:58 ` Pedro Alves
2013-01-24 1:15 ` [PATCH 2/3] Remove queue_position Yao Qi
2013-01-24 18:35 ` Tom Tromey
2013-01-24 18:53 ` Pedro Alves [this message]
2013-01-24 18:48 ` [PATCH 1/3] gdbserver: replace event_queue with QUEUE Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51018313.9030701@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox