Re: [PATCH 2/3] Remove queue_position.

Pedro Alves
2013-01-24T18:53:17Z

On 01/24/2013 01:13 AM, Yao Qi wrote:
> enum HEAD is never used and AFAICS, we don't need to insert element to
> event_queue in different places of the queue, so 'enum
> queue_position' is not needed. This patch is to remove it and
> simplify 'async_queue_event'.

Yeah. Thanks. This was one of the things I simplified
when I forked gdbserver's event-loop.c, but never got
to cleanup on the GDB side. Nowadays, I think that forking
was a mistake, and we should make gdb and gdbserver share
the same code.

>
> gdb:
>
> 2013-01-24 Yao Qi <yao@codesourcery.com>
>
> * event-loop.c (async_queue_event): Remove one parameter
> 'position'. Remove code handling 'position' == TAIL.
> (gdb_wait_for_event): Caller update.
> (check_async_event_handlers): Caller update.
> (poll_timers): Caller update.
> * event-loop.h (enum queue_position): Remove.

Okay, thanks.

--
Pedro Alves