From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10233 invoked by alias); 24 Jan 2013 18:53:17 -0000 Received: (qmail 10218 invoked by uid 22791); 24 Jan 2013 18:53:16 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Jan 2013 18:53:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0OIr9SJ021314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Jan 2013 13:53:09 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0OIr7xj023415; Thu, 24 Jan 2013 13:53:08 -0500 Message-ID: <51018313.9030701@redhat.com> Date: Thu, 24 Jan 2013 18:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Remove queue_position. References: <1358990040-10962-1-git-send-email-yao@codesourcery.com> <1358990040-10962-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1358990040-10962-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00608.txt.bz2 On 01/24/2013 01:13 AM, Yao Qi wrote: > enum HEAD is never used and AFAICS, we don't need to insert element to > event_queue in different places of the queue, so 'enum > queue_position' is not needed. This patch is to remove it and > simplify 'async_queue_event'. Yeah. Thanks. This was one of the things I simplified when I forked gdbserver's event-loop.c, but never got to cleanup on the GDB side. Nowadays, I think that forking was a mistake, and we should make gdb and gdbserver share the same code. > > gdb: > > 2013-01-24 Yao Qi > > * event-loop.c (async_queue_event): Remove one parameter > 'position'. Remove code handling 'position' == TAIL. > (gdb_wait_for_event): Caller update. > (check_async_event_handlers): Caller update. > (poll_timers): Caller update. > * event-loop.h (enum queue_position): Remove. Okay, thanks. -- Pedro Alves