Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Marc Khouzam <marc.khouzam@ericsson.com>
Cc: "'Tom Tromey'" <tromey@redhat.com>,
	"'Yao Qi'" <yao@codesourcery.com>,
	       "'gdb-patches@sourceware.org'"
	<gdb-patches@sourceware.org>
Subject: Re: [MI][patch v2] -break-list to specify "thread-group"
Date: Mon, 21 Jan 2013 18:54:00 -0000	[thread overview]
Message-ID: <50FD8EC9.507@redhat.com> (raw)
In-Reply-To: <E59706EF8DB1D147B15BECA3322E4BDC0878C0@eusaamb103.ericsson.se>

On 01/16/2013 04:58 PM, Marc Khouzam wrote:

> +  for (i = 0; VEC_iterate (int, inf_num, i, inf); ++i)
> +    {
> +      if (is_mi)
> +	{
> +	  char mi_group[10];
> +
> +	  sprintf (mi_group, "i%d", inf);

xsnprintf.

> @@ -28627,6 +28636,8 @@ memory location at which the breakpoint is set
>  @item What
>  logical location of the breakpoint, expressed by function name, file
>  name, line number
> +@item Thread-groups
> +list of inferiors to which this breakpoint applies

Should be, "list of thread groups".

Otherwise looks good to me.

Thanks,
-- 
Pedro Alves


  reply	other threads:[~2013-01-21 18:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 10:01 [MI][patch] " Marc Khouzam
2012-09-21 10:45 ` Marc Khouzam
2012-09-21 14:47   ` [MI][patch v2] " Marc Khouzam
2012-09-22 13:00     ` Yao Qi
2012-09-26 10:05       ` Marc Khouzam
2012-09-28 19:23         ` Tom Tromey
2012-10-01 16:10           ` Marc Khouzam
2012-10-01 16:17             ` Eli Zaretskii
2012-10-15 10:39             ` Marc Khouzam
2012-10-24 18:43               ` Marc Khouzam
2012-11-27 19:56                 ` Marc Khouzam
2012-11-28  6:07                   ` Abid, Hafiz
2012-11-30 18:35                     ` Tom Tromey
2012-09-28 19:21       ` Tom Tromey
2012-12-07 15:37       ` Pedro Alves
2012-12-07 15:44         ` Pedro Alves
2013-01-16 16:58           ` Marc Khouzam
2013-01-21 18:54             ` Pedro Alves [this message]
2013-01-22  0:09               ` Marc Khouzam
2012-09-28 19:10     ` Tom Tromey
2012-09-28 19:18     ` Tom Tromey
2012-09-21 18:12 ` [MI][patch] " André Pönitz
2012-09-21 18:54   ` Marc Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FD8EC9.507@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=marc.khouzam@ericsson.com \
    --cc=tromey@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox