From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97859-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1423 invoked by alias); 21 Jan 2013 18:54:15 -0000
Received: (qmail 1412 invoked by uid 22791); 21 Jan 2013 18:54:13 -0000
X-SWARE-Spam-Status: No, hits=-7.7 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jan 2013 18:54:08 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0LIs4XZ017994	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 21 Jan 2013 13:54:04 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r0LIs10u030877;	Mon, 21 Jan 2013 13:54:02 -0500
Message-ID: <50FD8EC9.507@redhat.com>
Date: Mon, 21 Jan 2013 18:54:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Marc Khouzam <marc.khouzam@ericsson.com>
CC: "'Tom Tromey'" <tromey@redhat.com>, "'Yao Qi'" <yao@codesourcery.com>,        "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [MI][patch v2] -break-list to specify "thread-group"
References: <F7CE05678329534C957159168FA70DEC5E11404FDC@EUSAACMS0703.eamcs.ericsson.se> <F7CE05678329534C957159168FA70DEC5E11404FE0@EUSAACMS0703.eamcs.ericsson.se> <F7CE05678329534C957159168FA70DEC5E11B177EA@EUSAACMS0703.eamcs.ericsson.se> <505DB611.70706@codesourcery.com> <50C20D19.1070704@redhat.com> <50C20EE6.2030103@redhat.com> <E59706EF8DB1D147B15BECA3322E4BDC0878C0@eusaamb103.ericsson.se>
In-Reply-To: <E59706EF8DB1D147B15BECA3322E4BDC0878C0@eusaamb103.ericsson.se>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00489.txt.bz2

On 01/16/2013 04:58 PM, Marc Khouzam wrote:

> +  for (i = 0; VEC_iterate (int, inf_num, i, inf); ++i)
> +    {
> +      if (is_mi)
> +	{
> +	  char mi_group[10];
> +
> +	  sprintf (mi_group, "i%d", inf);

xsnprintf.

> @@ -28627,6 +28636,8 @@ memory location at which the breakpoint is set
>  @item What
>  logical location of the breakpoint, expressed by function name, file
>  name, line number
> +@item Thread-groups
> +list of inferiors to which this breakpoint applies

Should be, "list of thread groups".

Otherwise looks good to me.

Thanks,
-- 
Pedro Alves