Re: [MI][patch v2] -break-list to specify "thread-group"

[Yao Qi <yao@codesourcery.com>]

On 09/21/2012 10:46 PM, Marc Khouzam wrote:
> or (if the bp applies to multiple inferiors, which I didn't quite
> out how to officially trigger, so I hacked the code to make sure
> the output was done properly in that case):
>

I don't know ether.  I can't think of a case that multiple inferiors 
share a single pspace.


> Can this patch go in as is?  Or can I get some guidance
> about how to handle this out-of-date MI output?
>

Maybe, we still need a test case for '-break-list' command here.

> #P src
> Index: gdb/breakpoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/breakpoint.c,v
> retrieving revision 1.704
> diff -u -r1.704 breakpoint.c
> --- gdb/breakpoint.c    17 Sep 2012 07:03:14 -0000      1.704
> +++ gdb/breakpoint.c    21 Sep 2012 14:40:23 -0000
> @@ -69,6 +69,7 @@
>   #include "gdb_regex.h"
>   #include "ax-gdb.h"
>   #include "dummy-frame.h"
> +#include "interps.h"
>

It is useless to include "interps.h" here.

>   #include "format.h"
>
> @@ -5779,6 +5780,46 @@
>     return bptypes[(int) type].description;
>   }
>
> +/* Output a field named 'thread-group' with a list as the value.  The
> +   elements of the list are obtained by splitting 'groups' on
> +   comma.  */
> +
> +static void
> +output_thread_groups (struct ui_out *uiout, const char *field_name, const char *xgroups)

This line is too long.

The id of inferiors is passed in XGROUPS, why don't we pass an array of 
integer?  In this way, it is easier, IMO, and we don't have to parse string.

-- 
Yao