From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29709 invoked by alias); 22 Sep 2012 13:00:24 -0000 Received: (qmail 29683 invoked by uid 22791); 22 Sep 2012 13:00:21 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 22 Sep 2012 12:59:45 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TFPJ9-0000G5-9A from Yao_Qi@mentor.com ; Sat, 22 Sep 2012 05:59:43 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 22 Sep 2012 05:59:43 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Sat, 22 Sep 2012 05:59:42 -0700 Message-ID: <505DB611.70706@codesourcery.com> Date: Sat, 22 Sep 2012 13:00:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Marc Khouzam CC: "gdb-patches@sourceware.org" Subject: Re: [MI][patch v2] -break-list to specify "thread-group" References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00466.txt.bz2 On 09/21/2012 10:46 PM, Marc Khouzam wrote: > or (if the bp applies to multiple inferiors, which I didn't quite > out how to officially trigger, so I hacked the code to make sure > the output was done properly in that case): > I don't know ether. I can't think of a case that multiple inferiors share a single pspace. > Can this patch go in as is? Or can I get some guidance > about how to handle this out-of-date MI output? > Maybe, we still need a test case for '-break-list' command here. > #P src > Index: gdb/breakpoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/breakpoint.c,v > retrieving revision 1.704 > diff -u -r1.704 breakpoint.c > --- gdb/breakpoint.c 17 Sep 2012 07:03:14 -0000 1.704 > +++ gdb/breakpoint.c 21 Sep 2012 14:40:23 -0000 > @@ -69,6 +69,7 @@ > #include "gdb_regex.h" > #include "ax-gdb.h" > #include "dummy-frame.h" > +#include "interps.h" > It is useless to include "interps.h" here. > #include "format.h" > > @@ -5779,6 +5780,46 @@ > return bptypes[(int) type].description; > } > > +/* Output a field named 'thread-group' with a list as the value. The > + elements of the list are obtained by splitting 'groups' on > + comma. */ > + > +static void > +output_thread_groups (struct ui_out *uiout, const char *field_name, const char *xgroups) This line is too long. The id of inferiors is passed in XGROUPS, why don't we pass an array of integer? In this way, it is easier, IMO, and we don't have to parse string. -- Yao