Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFC] Refactor doc on stop notification.
Date: Fri, 28 Dec 2012 02:52:00 -0000	[thread overview]
Message-ID: <50DD0954.8070105@codesourcery.com> (raw)
In-Reply-To: <83obhfmkoy.fsf@gnu.org>

On 12/28/2012 02:09 AM, Eli Zaretskii wrote:
>> +Otherwise, @value{GDBN} must be prepared to receive a
> I would delete the "Otherwise" part.  I don't think it adds anything
> to the text.
>

OK, I remove the first sentence, and keep the rest of paragraph, as it 
expresses that "when the notification may come in".

>> >+If the stub receives a @var{ack} packet and there are no
>> >+additional stop events to report, the stub shall return an @samp{OK}
>> >+response.  At this point, @value{GDBN} has finished processing a
>> >+notification and the stub has completed sending any queued events.
>> >+@value{GDBN} ignores additional notifications received before this
>> >+point.       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> "Before" or "after"?  If "before" is correct, then I don't think I
> understand what this paragraph wants to tell.
>

It is "before".  At point [1], GDB has finished processing %Stop.  GDB 
will ignore any %Stop notifications (in [2]), *before* point [1].

<- %Stop:T0505:XXXX;
....
-> vStopped
<- T0505:68f37db7;04:40f37db7;08:63850408;thread:p7526.7528;core:0;
-> vStopped
<- %Stop:T0505:XXXX; [2]
<- T0505:68e3fdb6;04:40e3fdb6;08:63850408;thread:p7526.7529;core:0;
-> vStopped
<- OK
  [1]

This paragraph is to tell that point [1] is the end of a processing to a 
notification.  After this point, GDB is ready again to process 
notification, and before this point, GDB ignore notifications.

>> >+The process of asynchronous notification can be illustrated by the
>> >+following example:
>> >+@smallexample
>> >+<- @code{%name:event}
>> >+@code{...}
>> >+-> @code{ack}
>> >+<- @code{event}
>> >+-> @code{ack}
>> >+<- @code{event}
>> >+-> @code{ack}
>> >+<- @code{OK}
>> >+@end smallexample
> I would suggest to consider putting here a real example, like the one
> you used to explain the issue to me.

My intention here is to add a template or a pattern for a given new 
notification, comprised of name, event and ack, to describe how rsp 
traffic looks like for notification in general.  IMO, it is more 
informative than a specific notification.

The word "example" may be misleading, how about this below?

The process of asynchronous notification can be illustrated by the
following template:
@smallexample
<- @code{%name:event}
@code{...}
-> @code{ack}
<- @code{event}
-> @code{ack}
<- @code{event}
-> @code{ack}
<- @code{OK}
@end smallexample
The asynchronous notification should define its @var{name},
@var{event} and @var{ack}.

-- 
Yao (齐尧)


  reply	other threads:[~2012-12-28  2:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17  8:04 Yao Qi
2012-12-17 16:30 ` Eli Zaretskii
2012-12-19  1:46   ` Yao Qi
2012-12-27 18:09     ` Eli Zaretskii
2012-12-28  2:52       ` Yao Qi [this message]
2012-12-28 11:23         ` Eli Zaretskii
2012-12-28 13:50           ` Yao Qi
2012-12-28 14:31             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50DD0954.8070105@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox