From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30626 invoked by alias); 28 Dec 2012 02:52:29 -0000 Received: (qmail 30612 invoked by uid 22791); 28 Dec 2012 02:52:28 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Dec 2012 02:52:22 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1ToQ3Y-0001xV-NE from Yao_Qi@mentor.com ; Thu, 27 Dec 2012 18:52:20 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 27 Dec 2012 18:52:20 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Thu, 27 Dec 2012 18:52:18 -0800 Message-ID: <50DD0954.8070105@codesourcery.com> Date: Fri, 28 Dec 2012 02:52:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Eli Zaretskii CC: Subject: Re: [RFC] Refactor doc on stop notification. References: <1355731419-21360-1-git-send-email-yao@codesourcery.com> <83fw34r682.fsf@gnu.org> <50D11C59.2060803@codesourcery.com> <83obhfmkoy.fsf@gnu.org> In-Reply-To: <83obhfmkoy.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00831.txt.bz2 On 12/28/2012 02:09 AM, Eli Zaretskii wrote: >> +Otherwise, @value{GDBN} must be prepared to receive a > I would delete the "Otherwise" part. I don't think it adds anything > to the text. > OK, I remove the first sentence, and keep the rest of paragraph, as it expresses that "when the notification may come in". >> >+If the stub receives a @var{ack} packet and there are no >> >+additional stop events to report, the stub shall return an @samp{OK} >> >+response. At this point, @value{GDBN} has finished processing a >> >+notification and the stub has completed sending any queued events. >> >+@value{GDBN} ignores additional notifications received before this >> >+point. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > "Before" or "after"? If "before" is correct, then I don't think I > understand what this paragraph wants to tell. > It is "before". At point [1], GDB has finished processing %Stop. GDB will ignore any %Stop notifications (in [2]), *before* point [1]. <- %Stop:T0505:XXXX; .... -> vStopped <- T0505:68f37db7;04:40f37db7;08:63850408;thread:p7526.7528;core:0; -> vStopped <- %Stop:T0505:XXXX; [2] <- T0505:68e3fdb6;04:40e3fdb6;08:63850408;thread:p7526.7529;core:0; -> vStopped <- OK [1] This paragraph is to tell that point [1] is the end of a processing to a notification. After this point, GDB is ready again to process notification, and before this point, GDB ignore notifications. >> >+The process of asynchronous notification can be illustrated by the >> >+following example: >> >+@smallexample >> >+<- @code{%name:event} >> >+@code{...} >> >+-> @code{ack} >> >+<- @code{event} >> >+-> @code{ack} >> >+<- @code{event} >> >+-> @code{ack} >> >+<- @code{OK} >> >+@end smallexample > I would suggest to consider putting here a real example, like the one > you used to explain the issue to me. My intention here is to add a template or a pattern for a given new notification, comprised of name, event and ack, to describe how rsp traffic looks like for notification in general. IMO, it is more informative than a specific notification. The word "example" may be misleading, how about this below? The process of asynchronous notification can be illustrated by the following template: @smallexample <- @code{%name:event} @code{...} -> @code{ack} <- @code{event} -> @code{ack} <- @code{event} -> @code{ack} <- @code{OK} @end smallexample The asynchronous notification should define its @var{name}, @var{event} and @var{ack}. -- Yao (齐尧)