Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Refactor doc on stop notification.
Date: Thu, 27 Dec 2012 18:09:00 -0000	[thread overview]
Message-ID: <83obhfmkoy.fsf@gnu.org> (raw)
In-Reply-To: <50D11C59.2060803@codesourcery.com>

> Date: Wed, 19 Dec 2012 09:46:01 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
> 
> Here is a real rsp traffic on notification Stop.
> 
> <- %Stop:T0505:98e7ffbf;04:4ce6ffbf;08:b1b6e54c;thread:p7526.7526;core:0;
> ....
> -> vStopped
> <- T0505:68f37db7;04:40f37db7;08:63850408;thread:p7526.7528;core:0;
> -> vStopped
> <-T0505:68e3fdb6;04:40e3fdb6;08:63850408;thread:p7526.7529;core:0;
> -> vStopped
> <- OK

Thanks, this explains quite a bit.

> How about the new version?

It's OK, after you take care of a few remaining problems:

> +See @xref{Notification Packets}.

Just "@xref", without the "See" part.  @xref already generates a "See".

> +Each notification is composed by three parts:
                        ^^^^^^^^^^^^^^^^^^^^^^^
"comprised of three parts"

> +Otherwise, @value{GDBN} must be prepared to receive a

I would delete the "Otherwise" part.  I don't think it adds anything
to the text.

> +If the stub receives a @var{ack} packet and there are no
> +additional stop events to report, the stub shall return an @samp{OK}
> +response.  At this point, @value{GDBN} has finished processing a
> +notification and the stub has completed sending any queued events.
> +@value{GDBN} ignores additional notifications received before this
> +point.       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

"Before" or "after"?  If "before" is correct, then I don't think I
understand what this paragraph wants to tell.

> +The process of asynchronous notification can be illustrated by the
> +following example:
> +@smallexample
> +<- @code{%name:event}
> +@code{...}
> +-> @code{ack}
> +<- @code{event}
> +-> @code{ack}
> +<- @code{event}
> +-> @code{ack}
> +<- @code{OK}
> +@end smallexample

I would suggest to consider putting here a real example, like the one
you used to explain the issue to me.

OK with those changes.

Thanks.


  reply	other threads:[~2012-12-27 18:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17  8:04 Yao Qi
2012-12-17 16:30 ` Eli Zaretskii
2012-12-19  1:46   ` Yao Qi
2012-12-27 18:09     ` Eli Zaretskii [this message]
2012-12-28  2:52       ` Yao Qi
2012-12-28 11:23         ` Eli Zaretskii
2012-12-28 13:50           ` Yao Qi
2012-12-28 14:31             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83obhfmkoy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox