Re: [RFA/commit] Port GDB to powerpc-lynx178.

[Yao Qi <yao@codesourcery.com>]

On 12/18/2012 02:17 PM, Joel Brobecker wrote:
> Just one request: Would you mind cutting out the quoted test that
> you are not replying to? It makes no sense to see emails where
> you have to scroll pages and pages before seeing a one-line comment.
>

OK, no problem.  I am used to giving comments with the context on 
function level, to make it clear where my comments apply.  I'll shorten 
the context if it is too long next time.

>>> > >+     AIX XCOFF files comes from the fact that there are no shared
>>> > >+     libraries on Lynx178.  So if the number of import files is
>>> > >+     different from zero, it cannot be a Lynx178 binary.  */
>>> > >+  if (xcoff_get_n_import_files (abfd) != 0)
>>> > >+    return GDB_OSABI_UNKNOWN;
>> >
>> >As your comments said, we need the function returning a flag
>> >indicating 'the xcoff file has shared libraries or not', and looks
>> >the precise number of import files doesn't matter here.  I suggest
>> >that rename function 'xcoff_get_n_import_files' to
>> >'xcoff_has_import_files'.
> While your suggestion may be good enough for today, there might
> come a day where someone will want the actual number of imports.
> Since it does not cost anything to provide that information,
> it would seem silly to spend any effort downgrading the function,
> and take the risk of having to undo those changes someday.

That is fine to me.

-- 
Yao (齐尧)