From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Port GDB to powerpc-lynx178.
Date: Mon, 17 Dec 2012 18:41:00 -0000 [thread overview]
Message-ID: <87y5gwwmh8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1355764695-5013-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 17 Dec 2012 12:18:15 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Tested on ppc-lynx178. Any comments before I commit?
Just a nit...
Joel> +/* Return the number of import files (shared libraries) that the given
Joel> + BFD depends on. Return -1 if this number could not be computed. */
Joel> +
Joel> +extern int
Joel> +xcoff_get_n_import_files (bfd *abfd)
Joel> +{
It's unusual to put 'extern' on the definition.
Tom
next prev parent reply other threads:[~2012-12-17 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 17:18 Joel Brobecker
2012-12-17 18:41 ` Tom Tromey [this message]
2012-12-18 4:56 ` Yao Qi
2012-12-18 6:17 ` Joel Brobecker
2012-12-18 8:29 ` Yao Qi
2012-12-18 15:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5gwwmh8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox