From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28108 invoked by alias); 18 Dec 2012 08:29:25 -0000 Received: (qmail 28100 invoked by uid 22791); 18 Dec 2012 08:29:24 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 08:29:19 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TksY9-00078D-UK from Yao_Qi@mentor.com ; Tue, 18 Dec 2012 00:29:17 -0800 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 18 Dec 2012 00:29:17 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Tue, 18 Dec 2012 00:29:16 -0800 Message-ID: <50D0293C.4010609@codesourcery.com> Date: Tue, 18 Dec 2012 08:29:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [RFA/commit] Port GDB to powerpc-lynx178. References: <1355764695-5013-1-git-send-email-brobecker@adacore.com> <50CFF750.2090905@codesourcery.com> <20121218061730.GE3273@adacore.com> In-Reply-To: <20121218061730.GE3273@adacore.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00618.txt.bz2 On 12/18/2012 02:17 PM, Joel Brobecker wrote: > Just one request: Would you mind cutting out the quoted test that > you are not replying to? It makes no sense to see emails where > you have to scroll pages and pages before seeing a one-line comment. > OK, no problem. I am used to giving comments with the context on function level, to make it clear where my comments apply. I'll shorten the context if it is too long next time. >>> > >+ AIX XCOFF files comes from the fact that there are no shared >>> > >+ libraries on Lynx178. So if the number of import files is >>> > >+ different from zero, it cannot be a Lynx178 binary. */ >>> > >+ if (xcoff_get_n_import_files (abfd) != 0) >>> > >+ return GDB_OSABI_UNKNOWN; >> > >> >As your comments said, we need the function returning a flag >> >indicating 'the xcoff file has shared libraries or not', and looks >> >the precise number of import files doesn't matter here. I suggest >> >that rename function 'xcoff_get_n_import_files' to >> >'xcoff_has_import_files'. > While your suggestion may be good enough for today, there might > come a day where someone will want the actual number of imports. > Since it does not cost anything to provide that information, > it would seem silly to spend any effort downgrading the function, > and take the risk of having to undo those changes someday. That is fine to me. -- Yao (齐尧)