From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: RFC: remove partial_symtab::objfile
Date: Fri, 30 Nov 2012 14:00:00 -0000 [thread overview]
Message-ID: <50B8BBF5.300@codesourcery.com> (raw)
In-Reply-To: <87fw3t8k01.fsf@fleche.redhat.com>
On 11/29/2012 06:01 AM, Tom Tromey wrote:
> This is a necessary step for symbol table location independence; but I
> see it as a general cleanup as well -- back-pointers are better avoided
> when possible, and it saves some tiny amount of memory.
It is a cleanup to me. What is "symbol table location independence"?
Do we have the description or discussion on it some where?
> @@ -2050,13 +2045,13 @@ xcoff_start_psymtab (struct objfile *objfile,
> are the information for includes and dependencies. */
>
> static struct partial_symtab *
> -xcoff_end_psymtab (struct partial_symtab *pst, const char **include_list,
> +xcoff_end_psymtab (struct objfile *objfile,
> + struct partial_symtab *pst, const char **include_list,
> int num_includes, int capping_symbol_number,
> struct partial_symtab **dependency_list,
> int number_dependencies, int textlow_not_set)
Why write in this way? to reduce the length of patch? or some other reason?
> @@ -2319,7 +2314,8 @@ scan_xcoff_symtab (struct objfile *objfile)
> each program csect, because their text
> sections need not be adjacent. */
> xcoff_end_psymtab
> - (pst, psymtab_include_list, includes_used,
> + (objfile,
> + pst, psymtab_include_list, includes_used,
> symnum_before, dependency_list,
> dependencies_used, textlow_not_set);
and here.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-11-30 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 22:01 Tom Tromey
2012-11-28 22:23 ` Pedro Alves
2012-11-30 14:00 ` Yao Qi [this message]
2012-11-30 16:31 ` Tom Tromey
2012-12-12 16:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8BBF5.300@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox