From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18144 invoked by alias); 30 Nov 2012 14:00:59 -0000 Received: (qmail 17792 invoked by uid 22791); 30 Nov 2012 14:00:54 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_BJ X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Nov 2012 14:00:47 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TeR94-0003g5-B1 from Yao_Qi@mentor.com ; Fri, 30 Nov 2012 06:00:46 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 30 Nov 2012 06:00:46 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Fri, 30 Nov 2012 06:00:45 -0800 Message-ID: <50B8BBF5.300@codesourcery.com> Date: Fri, 30 Nov 2012 14:00:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: RFC: remove partial_symtab::objfile References: <87fw3t8k01.fsf@fleche.redhat.com> In-Reply-To: <87fw3t8k01.fsf@fleche.redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00921.txt.bz2 On 11/29/2012 06:01 AM, Tom Tromey wrote: > This is a necessary step for symbol table location independence; but I > see it as a general cleanup as well -- back-pointers are better avoided > when possible, and it saves some tiny amount of memory. It is a cleanup to me. What is "symbol table location independence"? Do we have the description or discussion on it some where? > @@ -2050,13 +2045,13 @@ xcoff_start_psymtab (struct objfile *objfile, > are the information for includes and dependencies. */ > > static struct partial_symtab * > -xcoff_end_psymtab (struct partial_symtab *pst, const char **include_list, > +xcoff_end_psymtab (struct objfile *objfile, > + struct partial_symtab *pst, const char **include_list, > int num_includes, int capping_symbol_number, > struct partial_symtab **dependency_list, > int number_dependencies, int textlow_not_set) Why write in this way? to reduce the length of patch? or some other reason? > @@ -2319,7 +2314,8 @@ scan_xcoff_symtab (struct objfile *objfile) > each program csect, because their text > sections need not be adjacent. */ > xcoff_end_psymtab > - (pst, psymtab_include_list, includes_used, > + (objfile, > + pst, psymtab_include_list, includes_used, > symnum_before, dependency_list, > dependencies_used, textlow_not_set); and here. -- Yao (齐尧)