From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: remove partial_symtab::objfile
Date: Wed, 28 Nov 2012 22:23:00 -0000 [thread overview]
Message-ID: <50B68ED5.6020801@redhat.com> (raw)
In-Reply-To: <87fw3t8k01.fsf@fleche.redhat.com>
On 11/28/2012 10:01 PM, Tom Tromey wrote:
> I'm curious what people think of this patch.
>
> This is another old patch that was sitting on one of my branches for
> trying to split 'struct objfile'. However, I realized this patch is
> independent and pretty simple and so could go in separately.
>
> The basic idea is that partial_symtab doesn't really need a back-pointer
> to the objfile. In all places that this might be used, the information
> is already readily available, either directly or in some cases in the
> caller.
>
> This is a necessary step for symbol table location independence; but I
> see it as a general cleanup as well -- back-pointers are better avoided
> when possible, and it saves some tiny amount of memory.
You can probably guess that I agree with this, but FAOD:
+1.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-28 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 22:01 Tom Tromey
2012-11-28 22:23 ` Pedro Alves [this message]
2012-11-30 14:00 ` Yao Qi
2012-11-30 16:31 ` Tom Tromey
2012-12-12 16:51 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B68ED5.6020801@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox