Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH/arm] Backtrace through exception frames on arm/cortex-m target
Date: Tue, 13 Nov 2012 14:44:00 -0000	[thread overview]
Message-ID: <50A25CB7.6060205@codesourcery.com> (raw)
In-Reply-To: <201211131427.qADERVUl015787@glazunov.sibelius.xs4all.nl>

On 11/13/2012 10:27 PM, Mark Kettenis wrote:
>> +  unwound_sp = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
> Calling get_frame_register_unsign(this_frame, ...) in the unwinder
> itself is verboten!.

Really?  It is a surprise to me.  I see get_frame_register_unsigned is 
called in many other unwinders, for example,

*** alpha-mdebug-tdep.c:
alpha_mdebug_frame_unwind_cache[217] vfp = get_frame_register_unsigned 
(this_frame, PROC_FRAME_REG (proc_desc));

*** amd64obsd-tdep.c:
amd64obsd_trapframe_cache[373] sp = get_frame_register_unsigned 
(this_frame, AMD64_RSP_REGNUM);

*** arm-linux-tdep.c:
arm_linux_sigtramp_cache[258]  CORE_ADDR sp = 
get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);

*** avr-tdep.c:
avr_frame_unwind_cache[987]    this_base = get_frame_register_unsigned 
(this_frame, AVR_FP_REGNUM);

Am I missing something?

-- 
Yao


  reply	other threads:[~2012-11-13 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13 14:16 Yao Qi
2012-11-13 14:27 ` Mark Kettenis
2012-11-13 14:44   ` Yao Qi [this message]
2012-11-13 15:12     ` Mark Kettenis
2012-11-13 15:50 ` Joel Brobecker
2012-11-14  2:23   ` Yao Qi
2012-11-14  2:57     ` Joel Brobecker
2012-11-14  3:48       ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A25CB7.6060205@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox