From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH/arm] Backtrace through exception frames on arm/cortex-m target
Date: Tue, 13 Nov 2012 15:12:00 -0000 [thread overview]
Message-ID: <201211131511.qADFBNju008709@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <50A25CB7.6060205@codesourcery.com> (message from Yao Qi on Tue, 13 Nov 2012 22:44:07 +0800)
> Date: Tue, 13 Nov 2012 22:44:07 +0800
> From: Yao Qi <yao@codesourcery.com>
>
> On 11/13/2012 10:27 PM, Mark Kettenis wrote:
> >> + unwound_sp = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
> > Calling get_frame_register_unsign(this_frame, ...) in the unwinder
> > itself is verboten!.
>
> Really? It is a surprise to me. I see get_frame_register_unsigned is
> called in many other unwinders, for example,
>
> *** alpha-mdebug-tdep.c:
> alpha_mdebug_frame_unwind_cache[217] vfp = get_frame_register_unsigned
> (this_frame, PROC_FRAME_REG (proc_desc));
>
> *** amd64obsd-tdep.c:
> amd64obsd_trapframe_cache[373] sp = get_frame_register_unsigned
> (this_frame, AMD64_RSP_REGNUM);
>
> *** arm-linux-tdep.c:
> arm_linux_sigtramp_cache[258] CORE_ADDR sp =
> get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
>
> *** avr-tdep.c:
> avr_frame_unwind_cache[987] this_base = get_frame_register_unsigned
> (this_frame, AVR_FP_REGNUM);
>
> Am I missing something?
Ugh, no, you're right. It's unwinding THIS_FRAME in the unwinder that
is verboten. Objection withdrawn.
next prev parent reply other threads:[~2012-11-13 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 14:16 Yao Qi
2012-11-13 14:27 ` Mark Kettenis
2012-11-13 14:44 ` Yao Qi
2012-11-13 15:12 ` Mark Kettenis [this message]
2012-11-13 15:50 ` Joel Brobecker
2012-11-14 2:23 ` Yao Qi
2012-11-14 2:57 ` Joel Brobecker
2012-11-14 3:48 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211131511.qADFBNju008709@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox