From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Always include defs.h first.
Date: Thu, 08 Nov 2012 17:16:00 -0000 [thread overview]
Message-ID: <509BE8F3.4090605@redhat.com> (raw)
In-Reply-To: <000301cdbdd3$1b0f7780$512e6680$@muller@ics-cnrs.unistra.fr>
On 11/08/2012 05:04 PM, Pierre Muller wrote:
> Hi Pedro,
>
> I think you missed the python subdirectory...
> $ grep \"defs\.h\" */*.h
> python/py-event.h:#include "defs.h"
> python/py-events.h:#include "defs.h"
Indeed I have.
> The C sources also do not all include defs.h ...
Yeah. They're getting it from those headers. IMO, this makes it
easy to forget about it, and risk some change adding the inclusion
of a system header before including py-events.h, etc. But since
we don't have consensus, I'll leave it at that.
--
Pedro Alves
next prev parent reply other threads:[~2012-11-08 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 20:11 Pedro Alves
2012-11-08 1:34 ` Doug Evans
2012-11-08 16:49 ` Pedro Alves
2012-11-08 18:12 ` Doug Evans
2012-11-08 18:39 ` Joel Brobecker
2012-11-08 18:50 ` Pedro Alves
2012-11-08 18:55 ` Pedro Alves
2012-11-08 19:00 ` Doug Evans
2012-11-08 19:15 ` Joel Brobecker
2012-11-08 19:21 ` Tom Tromey
2012-11-08 3:49 ` Yao Qi
2012-11-08 5:04 ` Joel Brobecker
2012-11-08 16:56 ` Pedro Alves
2012-11-09 8:12 ` Yao Qi
2012-11-08 17:04 ` Pierre Muller
2012-11-08 17:16 ` Pedro Alves [this message]
2012-11-08 19:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509BE8F3.4090605@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox