From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22696 invoked by alias); 8 Nov 2012 17:16:49 -0000 Received: (qmail 22688 invoked by uid 22791); 8 Nov 2012 17:16:47 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 17:16:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA8HGbrb006612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Nov 2012 12:16:37 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA8HGaOM004096; Thu, 8 Nov 2012 12:16:36 -0500 Message-ID: <509BE8F3.4090605@redhat.com> Date: Thu, 08 Nov 2012 17:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Always include defs.h first. References: <20121107201107.25258.47267.stgit@brno.lan> <000301cdbdd3$1b0f7780$512e6680$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000301cdbdd3$1b0f7780$512e6680$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00199.txt.bz2 On 11/08/2012 05:04 PM, Pierre Muller wrote: > Hi Pedro, > > I think you missed the python subdirectory... > $ grep \"defs\.h\" */*.h > python/py-event.h:#include "defs.h" > python/py-events.h:#include "defs.h" Indeed I have. > The C sources also do not all include defs.h ... Yeah. They're getting it from those headers. IMO, this makes it easy to forget about it, and risk some change adding the inclusion of a system header before including py-events.h, etc. But since we don't have consensus, I'll leave it at that. -- Pedro Alves