From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Always include defs.h first.
Date: Thu, 08 Nov 2012 18:39:00 -0000 [thread overview]
Message-ID: <20121108183842.GM5103@adacore.com> (raw)
In-Reply-To: <CADPb22R1+-LVsre62Mm6HJgpiR+4KLktskMvcZG4nYESfvVMwQ@mail.gmail.com>
[I agree consistency is good]
> Note that gdbserver doesn't have defs.h and lots of files in common/ do the
>
> #ifdef GDBSERVER
> #include "server.h"
> #else
> #include "defs.h"
> #endif
Perhaps we should rename server.h into defs.h? Or move defs.h to
common?
--
Joel
next prev parent reply other threads:[~2012-11-08 18:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 20:11 Pedro Alves
2012-11-08 1:34 ` Doug Evans
2012-11-08 16:49 ` Pedro Alves
2012-11-08 18:12 ` Doug Evans
2012-11-08 18:39 ` Joel Brobecker [this message]
2012-11-08 18:50 ` Pedro Alves
2012-11-08 18:55 ` Pedro Alves
2012-11-08 19:00 ` Doug Evans
2012-11-08 19:15 ` Joel Brobecker
2012-11-08 19:21 ` Tom Tromey
2012-11-08 3:49 ` Yao Qi
2012-11-08 5:04 ` Joel Brobecker
2012-11-08 16:56 ` Pedro Alves
2012-11-09 8:12 ` Yao Qi
2012-11-08 17:04 ` Pierre Muller
2012-11-08 17:16 ` Pedro Alves
2012-11-08 19:37 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108183842.GM5103@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox