From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17933 invoked by alias); 8 Nov 2012 18:39:00 -0000 Received: (qmail 17923 invoked by uid 22791); 8 Nov 2012 18:38:59 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 18:38:53 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BBAC02E13C; Thu, 8 Nov 2012 13:38:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tE-1bHvMZVi4; Thu, 8 Nov 2012 13:38:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 754862E138; Thu, 8 Nov 2012 13:38:52 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B35CFC691E; Thu, 8 Nov 2012 10:38:42 -0800 (PST) Date: Thu, 08 Nov 2012 18:39:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] Always include defs.h first. Message-ID: <20121108183842.GM5103@adacore.com> References: <20121107201107.25258.47267.stgit@brno.lan> <509BE290.4000104@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00202.txt.bz2 [I agree consistency is good] > Note that gdbserver doesn't have defs.h and lots of files in common/ do the > > #ifdef GDBSERVER > #include "server.h" > #else > #include "defs.h" > #endif Perhaps we should rename server.h into defs.h? Or move defs.h to common? -- Joel