From: Phil Muldoon <pmuldoon@redhat.com>
To: gdb-patches@sourceware.org, Kevin Pouget <kevin.pouget@gmail.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>,
aburgess@broadcom.com
Subject: Re: [PATCH] improve python finish breakpoint for exceptions/longjmp case.
Date: Thu, 11 Oct 2012 06:46:00 -0000 [thread overview]
Message-ID: <50766B4A.6010209@redhat.com> (raw)
In-Reply-To: <5075E39F.2050402@broadcom.com>
On 10/10/2012 10:07 PM, Andrew Burgess wrote:
> *ping* *again*
>
> In Summary,
>
> - python finish breakpoint, documentation looks good.
> - implementation does not match documentation in exception/longjmp case
> - test case does not match documentation
> - broken test relies on target implementation of exceptions
> - this patch fixes some, but not all of the issues
> - as far as I know I introduce no new issues
> - will raise a bug for one issue I know about before I commit this patch, and fill in bug id.
>
>
> Anyone interested?
>
> Thanks,
> Andrew
The patch looks fine to me, but I cannot give you permission to commit your work. I have cc'd kevin (the original author), and a maintainer I picked by random.
Cheers
Phil
next prev parent reply other threads:[~2012-10-11 6:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 14:58 Andrew Burgess
2012-09-24 10:22 ` Kevin Pouget
2012-10-01 16:33 ` Andrew Burgess
2012-10-01 16:30 ` Andrew Burgess
2012-10-10 21:08 ` Andrew Burgess
2012-10-11 6:46 ` Phil Muldoon [this message]
2012-10-11 16:32 ` Jan Kratochvil
2012-10-15 20:40 ` Andrew Burgess
2012-10-17 16:28 ` Jan Kratochvil
2012-10-24 20:48 ` Andrew Burgess
2012-10-25 6:13 ` Jan Kratochvil
2012-10-25 19:23 ` Andrew Burgess
2012-10-30 17:41 ` Jan Kratochvil
2012-11-06 14:24 ` Andrew Burgess
2012-11-22 18:15 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50766B4A.6010209@redhat.com \
--to=pmuldoon@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=kevin.pouget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox