From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30880 invoked by alias); 11 Oct 2012 06:46:46 -0000 Received: (qmail 30869 invoked by uid 22791); 11 Oct 2012 06:46:43 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Oct 2012 06:46:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9B6ka8o026108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 11 Oct 2012 02:46:36 -0400 Received: from localhost.localdomain (ovpn-116-77.ams2.redhat.com [10.36.116.77]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9B6kYfs023248; Thu, 11 Oct 2012 02:46:35 -0400 Message-ID: <50766B4A.6010209@redhat.com> Date: Thu, 11 Oct 2012 06:46:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: gdb-patches@sourceware.org, Kevin Pouget , Jan Kratochvil , aburgess@broadcom.com Subject: Re: [PATCH] improve python finish breakpoint for exceptions/longjmp case. References: <505C805A.1050400@broadcom.com> <5069C511.90404@broadcom.com> <5075E39F.2050402@broadcom.com> In-Reply-To: <5075E39F.2050402@broadcom.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00170.txt.bz2 On 10/10/2012 10:07 PM, Andrew Burgess wrote: > *ping* *again* > > In Summary, > > - python finish breakpoint, documentation looks good. > - implementation does not match documentation in exception/longjmp case > - test case does not match documentation > - broken test relies on target implementation of exceptions > - this patch fixes some, but not all of the issues > - as far as I know I introduce no new issues > - will raise a bug for one issue I know about before I commit this patch, and fill in bug id. > > > Anyone interested? > > Thanks, > Andrew The patch looks fine to me, but I cannot give you permission to commit your work. I have cc'd kevin (the original author), and a maintainer I picked by random. Cheers Phil